Sylvestre's blog

Firefox 29 beta 4 Desktop has just been released. In term of numbers (changeset or diff), this release is similar to the beta 3.
That won't be a surprise but most of the changes in this beta have been related to Australis, Sync and the UITour.

• 46 changesets
• 120 files changed
• 2313 insertions
• 489 deletions

Nick Alexander	Bug 983350 - Include User-Agent header for FxAccount and TokenServer requests. r=rnewman, a=sylvestre
Olli Pettay	Bug 987140 - Return width/height from the most recent image request. r=bz, a=sledru
Mihai Sucan	Bug 950430 - Potential fix for intermittent browser_webconsole_chrome.js | Test timed out. a=test-only
Matthew Noorenberghe	Bug 885139 - Notify consumers about LWT optimization and listen for it in LightweightThemeListener. r=jaws a=Sylvestre
Matthew Noorenberghe	Bug 988144 - UITour: Highlight effects don't occur if a highlight is moved to a different target with the same effect. r=Unfocused a=Sylvestre
Tim Nguyen	Bug 983801 - Remove border radius from bookmarks panel submenus on Windows 8 r=mdeboer a=sylvestre
Mike de Boer	Bug 987443: [Australis] fix zoom button label rounding. r=Gijs a=sylvestre
Gijs Kruitbosch	[Australis] Bug 987177 - invalidate wrapper's node reference, r=jaws, a=sylvestre
Gijs Kruitbosch	[Australis] Bug 987177 - make destroyWidget clear caches for XUL wrappers, r=jaws, a=sylvestre
Brandon Cheng	Bug 893661 - (Australis) Back button and toolbar slightly smaller than design spec; r=gijs,jaws,a=sylvestre
Mike de Boer	Bug 985416: update visual appearance of dropmarker open state. r=Gijs, a=sylvestre
Jason Smith	Bug 985274 - Ensure generated callback function handles string objects. r=drno, a=test-only
Ryan VanderMeulen	Bug 909305 - Replace mozilla-banner.gif with a plain blue image in 163504-2*.html since we aren't trying to test individual pixel differences in resized image painting there. r=tn, a=test-only
Ryan VanderMeulen	Bug 919482 - Replace mozilla-banner.gif with a plain blue image in 163504-1*.html since we aren't trying to test individual pixel differences in resized image painting there. r=tn, a=test-only
Geoff Brown	Bug 915449 - Get EditText view instead of using Solo.getEditText. r=mcomella, a=test-only
Rick Eyre	Bug 987076 - Construct HTMLMediaElement::mTextTrackManager lazily. r=roc, a=sledru
James Hugman	Bug 958709 - Catch the intent from the synthesized APK to kill the process. r=mfinkle, r=mhaigh, a=sledru
Richard Newman	Bug 987294 - Unsafe access to mTabsChangedListeners in Tabs. r=bnicholson, a=sylvestre
Richard Newman	Bug 984723 - Rework intervals and scheduling for Android Sync. r=nalexander, a=sylvestre
Mark Capella	Bug 978731 - Cursor position jumps around, dragging handles moves text. r=wesj, a=sledru
Myk Melez	Bug 982557 - Migrate old prefs and set apkPackageName after updating app via APK. r=mfinkle, a=sledru
Mark Hammond	Bug 988051 - Lazy-load FxAccountsClient module. r=rnewman, a=sledru
Michael Comella	Bug 957894 - Update account pickling code for Firefox Accounts. r=nalexander, a=sledru
Boris Zbarsky	Bug 987003 - Be more careful sandboxing javascript: URLs. r=bholley, a=sledru
Randell Jesup	Bug 986762 - Don't release DataChannelConnection on transient thread on readblob failure. r=smaug, a=sledru
Ryan VanderMeulen	Backed out changeset efb3bb0642a0 (Bug 986762) for bustage.
Monica Chew	Bug 989232: Fix failure in testSecurity/testSafeBrowsingNotificationBar.js (r=gcp,a=sledru)
Brian R. Bondy	Bug 981166 - Turn off Metro Firefox and cleanup DEH registration. r=rstrong, jimm. a=sledru
Brian R. Bondy	Bug 988853 - Disable Metro builds on secondary configs. r=jimm. a=lsblakk
Richard Newman	Bug 965811 - Support Firefox Account-based Sync in SendTabActivity. r=nalexander, a=lsblakk
Matthew Noorenberghe	Bug 941862 - UITour: Support a callback to notify when the menu panel opens while the menu button is an info panel target. r=Unfocused a=Sylvestre
Matthew Noorenberghe	Bug 988305 - UITour: getTarget should catch exceptions from a target's query function. r=Unfocused a=Sylvestre
Gijs Kruitbosch	Bug 985958 - fix CSS rules to make :active style work, r=mconley, a=sylvestre
Brian R. Bondy	Bug 961676. r=rstrong. a=abillings
Mike de Boer	Bug 987461: prevent bookmark menu button dropmarker icon to stretch when placed in certain toolbars. r=Gijs, a=sylvestre
Mike de Boer	Bug 957151: fix styling of primary toolbar buttons on the bookmarks toolbar on Linux. r=Gijs, a=sylvestre
Mike Conley	Bug 986920 - New tab button has equal z-index to non-selected tabs in Windows Classic mode. r=Gijs, a=sylvestre
Matthew Noorenberghe	Bug 979747 - Inherit text color on toolbars above the titlebar on Windows Classic. f=Gijs r=mikedeboer a=Sylvestre
Matthew Noorenberghe	Bug 879921 - Use the "tabbable" class to make the new tab page's close button tabbable. r=Gijs a=Sylvestre
Matthew Noorenberghe	Bug 879921 - Replace GTK close icons on Linux with our own except for on menus and dialog buttons. r=Gijs a=Sylvestre
Jared Wein	Bug 989133 - Add a soft hyphen to the character encoding label for en-US to avoid auto-hyphenation. r=MattN, a=sylvestre
Jared Wein	Bug 962884 - Offer opt-out from auto-hyphenation for labels in the menu panel. r=Gijs a=lsblakk
Jared Wein	Bug 940393 - Win8: Text color on inactive tabs makes text very hard to read. r=gijs, a=sylvestre
Gijs Kruitbosch	Bug 989009 - should theme live bookmark submenu items correctly, r=mak, a=sylvestre

r= means reviewed by
a= means uplift approved by

Previous changelogs:

• Firefox 29 beta 2 to beta 3

In order to improve the feedback and the beta releases of Firefox, we are going to start publishing some information on beta releases.
For this, we are using the mercurial repository and using these two tags/revisions: --rev "ancestor(FIREFOX_29_0b2_RELEASE,FIREFOX_29_0b3_RELEASE)::FIREFOX_29_0b3_RELEASE" (See bsmedberg's blog post for more information on this syntax).

We are ignoring the commit from the ffxbld robot.

Firefox 29 beta 3 release(compared to Firefox 29 beta 2)
Here are some numbers:

• 49 changesets
• 112 files changed
• 2174 insertions
• 423 deletions

List of changes:
Philipp Sackl: Bug 979938 - Delay the display of the tab close button to avoid visual noise. r=Dao, a=sylvestre
Masayuki Nakano: Bug 981963 Ignore following char message if its wParam is 0 r=jimm, a=sledru
JW Wang: Bug 907162 - Fix MediaDecoderStateMachine might dispatch MediaDecoder::PlaybackEnded more than once and trigger multiple 'ended' events in HTMLMediaElement. r=cpearce, a=sledru
JW Wang: Bug 934794 - Fix failing to update stream blocking status when endBlockingDecisions == mStateComputedTime. r=roc, a=sledru
Olli Pettay: Bug 985988 = Event handlers should update preventDefault flag similar way to event.preventDefault(). r=masayuki, a=sledru
Brandon Benvie: Bug 970172 - Prevent VariablesView Variables from handling clicks while editing. r=vporof, a=sledru
Brian Nicholson: Bug 962103 - Make progress bar overlap content. r=lucasr, a=sledru
Brian Nicholson: Bug 962103 - Fix progress bar visibility on pre-Honeycomb devices. r=lucasr, a=sledru
John Schoenick: Bug 985859 - navigator.mimeTypes access should be case-insensitive. r=bsmedberg, a=sledru
Sebastian Hengst: Bug 982615 - Sync panel is not entirely displayed in localized builds. r=mak, a=gavin
Bobby Holley: Bug 986542 - Don't categorically disable script for detached docshells. r=bz, a=sledru
Gavin Sharp: Bug 955950 - Add pref to disable "reset Firefox" nag. r=MattN, a=sledru
Ryan VanderMeulen: Bug 985859 - Adding missing include to fix bustage. a=bustage
Shane Caraveo: Bug 915835 fix leak in socialmarks event listeners, r=markh, a=lsblakk
Chris Karlof: Bug 983256 - Change the client generated expiration time in FxA assertions to be 'forever'. r=jedp, a=lsblakk
Shane Caraveo: Bug 984628 fix social button states, r=markh, a=sylvestre
Nathan Froyd: Bug 942411 - Set the src of the iframe after adding it to the document. a=test-only
Phil Ringnalda: Bug 863658 - Replace mozilla-banner.gif with a plain blue image in 359903-2.html since we aren't trying to test individual pixel differences in resized image painting there. r=bz, a=test-only
Ryan VanderMeulen: Bug 948389 - Replace mozilla-banner.gif with a plain blue image in 405577-1.html since we aren't trying to test individual pixel differences in resized image painting there. r=roc, a=test-only
Brian Grinstead: Bug 962931 - Request longer timeout for browser_webconsole_split.js. r=msucan, a=test-only
Brian R. Bondy: Bug 981166 - Turn off Metro Firefox and cleanup DEH registration. r=rstrong, jimm. a=sylvestre
Nicholas Hurley: Bug 978759 - Fix shutdown crash in seer. r=mcmanus, a=sledru
Margaret Leibovic: Bug 943262 - Use CharsetMenu.jsm instead of charsetTitles.properties for Character Encoding menu items. r=bnicholson, a=sledru
Sid Stamm: Bug 835357 - Fix telemetry probes for DNT so they accumulate before the pings are sent. r=mcmanus, a=sledru
Ryan VanderMeulen: Backed out the requestCompleteLog part of Bug 942411 because it wasn't needed for the fix anyway. a=bustage
Brian Smith :: Return the correct error message when no potential issuers are found during path bulding in insanity::pkix, r=keeler a=sylvestre
Brian Smith: Bug 978120, Part 1: Make nsIX509Cert.setCerttrust, and nsIX509CertDB.addCert, and nsIX509CertDB2.addCertFromBase64 work on Android and B2G, r=keeler a=sylvestre
Brian Smith :: part 2: Enable more PSM xpcshell tests on Android and B2G, r=keeler a=testonly
Margaret Leibovic: Bug 982181 - Hide home banner after it is animated off screen, to avoid intercepting click events on pre-honeycomb devices. r=lucasr a=sledru
Ryan VanderMeulen: Backed out changesets d3352d36dbdf and e74b6a1da573 (Bug 978120) and changeset 816c209eaa71 (Bug 978528) for Android xpcshell failures.
Monica Chew :: Force url classifier clients to specify which tables to lookup, add a pref to skip hash completion checks (r=gcp,ba=sledru)
Matthew Noorenberghe: Bug 985786 - [10.6] Make the button to leave fullscreen match the styles of other toolbarbuttons and fix its missing image. r=mconley a=Sylvestre
Marco Bonardo: Bug 983571 - browser.bookmarks.autoExportHTML = true no longer works. r=Yoric a=sylvestre
Marco Bonardo: Backout 450a302d1ffa (Bug 983571) due to xpcshell failures
Monica Chew :: Rename urlclassifier.download_block_table and urlclassifier.download_allow_table (r=gcp,a=sledru)
Marco Bonardo: Bug 983571 - browser.bookmarks.autoExportHTML = true no longer works. r=Yoric a=sylvestre
Masatoshi Kimura: Bug 986347 - Restore accidentaly removed HasBogusPopupsDropShadowOnMultiMonitor() call. r=jimm a=sylvestre
Mike de Boer :: restore sidebar splitter and header styles on Windows 8. r=jaws, a=sledru.
Mike Conley: Bug 984156 - Make subview footer menuseparators have a non-zero height to prevent bookmarks folder scrolling issues. r=mak, a=sledru.
Gijs Kruitbosch: Bug 986529 - invert tab close icons on windows classic, r=jaws, a=sledru.
Tim Nguyen: Bug 984979 - Fix back button :active state on Windows 8, r=gijs, a=sledru.
Gijs Kruitbosch: Bug 985815 - fix customtoolbars test so it doesn't break subsequent tests, r=jaws, a=sledru.
Gijs Kruitbosch: Bug 985815 - propagate collapsed state to other windows, add test. r=jaws, a=sledru.
Gijs Kruitbosch: Bug 987615 - fix layout of buttons which are too long in customize mode, r=jaws, a=sledru.
Steven MacLeod: Bug 967028 - Use a SHistoryListener to collect entries from history.pushState(). r=Yoric, a=sylvestre
Jonathan Watt: Bug 959128 - Fix transforms of clipPath content for clipPath being used within SVG-in-OpenType glyph. r=heycam, a=sylvestre
Brian R. Bondy: Backout 7971f738a6cd temporarily as a safety precaution. r=jimm, rsrong, me. a=me
Ehsan Akhgari: Backed out 2 changesets (Bug 957652) because Bug 957431 is being backed out, a=sylvestre
Ehsan Akhgari: Backed out 2 changesets (Bug 957431) because we decided we're keeping Attr.ownerElement in the end; a=sylvestre ba=me
r= means reviewed by
a= means uplift approved by

If you have any suggestion to improve this for the next report, don't hesitate!

Using the AWS donation, David Suarez and myself have been able to rebuild the whole archive with Clang 3.4.
The rebuild has been done January 10th but, with my new job, I did not find the time to publish the result.
Releases after releases, the results are getting better and better.

Currently, 2193 packages in the archive are failing to build from source.
That is roughly the same number of build failures as with the precedent rebuild with Clang 3.3.
However, this is good news for two reasons:
* the number of new packages in Debian increased (18854 at time of the 3.3 release, 21204 for the 3.4)
* clang 3.4 has more checks and error detections.

I also started to update clang to make it closer to gcc. For example, I transformed wrong usage of -O (> 6) error to be treated as regular warning.

However, a critical bug has emerged during this release. When using -D_FORTIFY_SOURCE=2 (which is the case of many Debian packages), the binaries produced freeze (infinity loop in the ASM). This has been reported upstream as bug 16821 and concerns about 150 packages (including Firefox, gcc, LLVM, etc). Hopefully, this will be fixed in 3.5 (this is unlikely for 3.4.1).

About the new build failures, now, Clang triggers an error (or warning + -Werror) on:

* Wrong usage of the default argument (should be done in the definition)
16 occurrences

* Usage of C++11 feature without the appropriate argument
7 occurrences

* Unused static const declaration
5 occurrences

* Recursive template instantiation exceeded
4 occurrences

* Defitinion of a builtin function
3 occurrences

* Read-only variable is not assignable
2 occurrences

By the way, I proposed a Google Summer of Code Project to work faster on a support of Debian built by Clang. As requirements, I asked students to fix some bugs, they already did a great job.

Lately, we, the release team at Mozilla, have started to use again the MozillaReleases account on Twitter.

We are publishing news about the releases, new features, interesting bugs, etc.

If you have suggestions (more technical, more bug reports, etc), don't hesitate to share them in the comments.

Just a small blog post to LLVM developers that the automatic scan-build reports on LLVM+Clang+LLDB+compiler-rt are now run using LLVM nightly.

That brings few advantages:
* New checks quickly available for the LLVM developer community
* Quick feedbacks for scan-build developers on the whole code base
* Automatic testing of the packages generated