Bug Summary

File:var/lib/jenkins/workspace/firefox-scan-build/config/nsinstall.c
Warning:line 152, column 7
2nd function call argument is an uninitialized value

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple x86_64-pc-linux-gnu -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name nsinstall.c -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -analyzer-config-compatibility-mode=true -mrelocation-model pic -pic-level 2 -pic-is-pie -mframe-pointer=none -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -fdebug-compilation-dir=/var/lib/jenkins/workspace/firefox-scan-build/obj-x86_64-pc-linux-gnu/config -fcoverage-compilation-dir=/var/lib/jenkins/workspace/firefox-scan-build/obj-x86_64-pc-linux-gnu/config -resource-dir /usr/lib/llvm-18/lib/clang/18 -D XP_UNIX -D DEBUG=1 -D UNICODE -D _UNICODE -I /var/lib/jenkins/workspace/firefox-scan-build/config -I /var/lib/jenkins/workspace/firefox-scan-build/obj-x86_64-pc-linux-gnu/config -I /var/lib/jenkins/workspace/firefox-scan-build/obj-x86_64-pc-linux-gnu/dist/include -I /var/lib/jenkins/workspace/firefox-scan-build/obj-x86_64-pc-linux-gnu/dist/include/nspr -internal-isystem /usr/lib/llvm-18/lib/clang/18/include -internal-isystem /usr/local/include -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/14/../../../../x86_64-linux-gnu/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -O3 -std=gnu99 -ferror-limit 19 -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -analyzer-checker optin.performance.Padding -analyzer-output=html -analyzer-config stable-report-filename=true -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /tmp/scan-build-2024-07-27-022226-2793976-1 -x c /var/lib/jenkins/workspace/firefox-scan-build/config/nsinstall.c
1/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
2/* This Source Code Form is subject to the terms of the Mozilla Public
3 * License, v. 2.0. If a copy of the MPL was not distributed with this
4 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
5/*
6** Netscape portable install command.
7**
8** Brendan Eich, 7/20/95
9*/
10#include <stdio.h> /* OSF/1 requires this before grp.h, so put it first */
11#include <assert.h>
12#include <fcntl.h>
13#include <errno(*__errno_location ()).h>
14#include <dirent.h>
15#include <limits.h>
16#include <grp.h>
17#include <pwd.h>
18#include <stdio.h>
19#include <stdlib.h>
20#include <string.h>
21#include <unistd.h>
22#include <utime.h>
23#include <sys/types.h>
24#include <sys/stat.h>
25#include "pathsub.h"
26
27#ifdef HAVE_GETOPT_H
28# include <getopt.h>
29#endif
30
31#ifdef SUNOS4
32# include "sunos4.h"
33#endif
34
35#ifdef NEXTSTEP
36# include <bsd/libc.h>
37#endif
38
39#ifdef __QNX__
40# include <unix1.h>
41#endif
42
43#ifdef NEED_S_ISLNK
44# if !defined(S_ISLNK) && defined(S_IFLNK0120000)
45# define S_ISLNK(a)((((a)) & 0170000) == (0120000)) (((a) & S_IFMT0170000) == S_IFLNK0120000)
46# endif
47#endif
48
49#ifndef _DIRECTORY_SEPARATOR"/"
50# define _DIRECTORY_SEPARATOR"/" "/"
51#endif /* _DIRECTORY_SEPARATOR */
52
53#ifdef NEED_FCHMOD_PROTO
54extern int fchmod(int fildes, mode_t mode);
55#endif
56
57static void usage(void) {
58 fprintf(stderrstderr,
59 "usage: %s [-C cwd] [-L linkprefix] [-m mode] [-o owner] [-g group]\n"
60 " %*s [-DdltR] file [file ...] directory\n",
61 program, (int)strlen(program), "");
62 exit(2);
63}
64
65static int mkdirs(char* path, mode_t mode) {
66 char* cp;
67 struct stat sb;
68 int res;
69 int l;
70
71 /* strip trailing "/." */
72 l = strlen(path);
73 if (l > 1 && path[l - 1] == '.' && path[l - 2] == '/') path[l - 2] = 0;
74
75 while (*path == '/' && path[1] == '/') path++;
76 for (cp = strrchr(path, '/'); cp && cp != path && *(cp - 1) == '/'; cp--);
77 if (cp && cp != path) {
78 *cp = '\0';
79 if ((lstat(path, &sb) < 0 || !S_ISDIR(sb.st_mode)((((sb.st_mode)) & 0170000) == (0040000))) &&
80 mkdirs(path, mode) < 0) {
81 return -1;
82 }
83 *cp = '/';
84 }
85
86 res = mkdir(path, mode);
87 if ((res != 0) && (errno(*__errno_location ()) == EEXIST17))
88 return 0;
89 else
90 return res;
91}
92
93static uid_t touid(char* owner) {
94 struct passwd* pw;
95 uid_t uid;
96 char* cp;
97
98 pw = getpwnam(owner);
99 if (pw) return pw->pw_uid;
100 uid = strtol(owner, &cp, 0);
101 if (uid == 0 && cp == owner) fail("cannot find uid for %s", owner);
102 return uid;
103}
104
105static gid_t togid(char* group) {
106 struct group* gr;
107 gid_t gid;
108 char* cp;
109
110 gr = getgrnam(group);
111 if (gr) return gr->gr_gid;
112 gid = strtol(group, &cp, 0);
113 if (gid == 0 && cp == group) fail("cannot find gid for %s", group);
114 return gid;
115}
116
117static void copyfile(char* name, char* toname, mode_t mode, char* group,
118 char* owner, int dotimes, uid_t uid, gid_t gid) {
119 int fromfd, tofd = -1, cc, wc, exists;
120 char buf[BUFSIZ8192], *bp;
121 struct stat sb, tosb;
122 struct utimbuf utb;
123
124 exists = (lstat(toname, &tosb) == 0);
16
←
Assuming the condition is false
→
125
126 fromfd = open(name, O_RDONLY00);
127 if (fromfd < 0 || fstat(fromfd, &sb) < 0) fail("cannot access %s", name);
17
←
Assuming 'fromfd' is < 0
→
128 if (exists
17.1
'exists' is 0
) {
18
←
Taking false branch
→
129 if (S_ISREG(tosb.st_mode)((((tosb.st_mode)) & 0170000) == (0100000))) {
130 /* See if we can open it. This is more reliable than 'access'. */
131 tofd = open(toname, O_CREAT0100 | O_WRONLY01, 0666);
132 }
133 if (tofd < 0) {
134 (void)(S_ISDIR(tosb.st_mode)((((tosb.st_mode)) & 0170000) == (0040000)) ? rmdir : unlink)(toname);
135 }
136 }
137 if (tofd
18.1
'tofd' is < 0
 < 0) {
19
←
Taking true branch
→
138 tofd = open(toname, O_CREAT0100 | O_WRONLY01, 0666);
139 if (tofd < 0) fail("cannot create %s", toname);
20
←
Assuming 'tofd' is >= 0
→
21
←
Taking false branch
→
140 }
141
142 bp = buf;
143 while ((cc = read(fromfd, bp, sizeof buf)) > 0) {
22
←
Assuming the condition is false
→
23
←
Loop condition is false. Execution continues on line 150
→
144 while ((wc = write(tofd, bp, (unsigned int)cc)) > 0) {
145 if ((cc -= wc) == 0) break;
146 bp += wc;
147 }
148 if (wc < 0) fail("cannot write to %s", toname);
149 }
150 if (cc < 0) fail("cannot read from %s", name);
24
←
Assuming 'cc' is >= 0
→
25
←
Taking false branch
→
151
152 if (ftruncate(tofd, sb.st_size) < 0) fail("cannot truncate %s", toname);
26
←
2nd function call argument is an uninitialized value
153#if !defined(VMS)
154 if (dotimes) {
155 utb.actime = sb.st_atimest_atim.tv_sec;
156 utb.modtime = sb.st_mtimest_mtim.tv_sec;
157 if (utime(toname, &utb) < 0) fail("cannot set times of %s", toname);
158 }
159# ifdef HAVE_FCHMOD
160 if (fchmod(tofd, mode) < 0)
161# else
162 if (chmod(toname, mode) < 0)
163# endif
164 fail("cannot change mode of %s", toname);
165#endif
166 if ((owner || group) && fchown(tofd, uid, gid) < 0)
167 fail("cannot change owner of %s", toname);
168
169 /* Must check for delayed (NFS) write errors on close. */
170 if (close(tofd) < 0) fail("cannot write to %s", toname);
171 close(fromfd);
172#if defined(VMS)
173 if (chmod(toname, (mode & (S_IREAD0400 | S_IWRITE0200))) < 0)
174 fail("cannot change mode of %s", toname);
175 if (dotimes) {
176 utb.actime = sb.st_atimest_atim.tv_sec;
177 utb.modtime = sb.st_mtimest_mtim.tv_sec;
178 if (utime(toname, &utb) < 0) fail("cannot set times of %s", toname);
179 }
180#endif
181}
182
183static void copydir(char* from, char* to, mode_t mode, char* group, char* owner,
184 int dotimes, uid_t uid, gid_t gid) {
185 DIR* dir;
186 struct dirent* ep;
187 struct stat sb;
188 char *base, *destdir, *direntry, *destentry;
189
190 base = xbasename(from);
191
192 /* create destination directory */
193 destdir = xmalloc((unsigned int)(strlen(to) + 1 + strlen(base) + 1));
194 sprintf(destdir, "%s%s%s", to, _DIRECTORY_SEPARATOR"/", base);
195 if (mkdirs(destdir, mode) != 0) {
196 fail("cannot make directory %s\n", destdir);
197 free(destdir);
198 return;
199 }
200
201 if (!(dir = opendir(from))) {
202 fail("cannot open directory %s\n", from);
203 free(destdir);
204 return;
205 }
206
207 direntry = xmalloc((unsigned int)PATH_MAX4096);
208 destentry = xmalloc((unsigned int)PATH_MAX4096);
209
210 while ((ep = readdir(dir))) {
211 if (strcmp(ep->d_name, ".") == 0 || strcmp(ep->d_name, "..") == 0) continue;
212
213 sprintf(direntry, "%s/%s", from, ep->d_name);
214 sprintf(destentry, "%s%s%s", destdir, _DIRECTORY_SEPARATOR"/", ep->d_name);
215
216 if (stat(direntry, &sb) == 0 && S_ISDIR(sb.st_mode)((((sb.st_mode)) & 0170000) == (0040000)))
217 copydir(direntry, destdir, mode, group, owner, dotimes, uid, gid);
218 else
219 copyfile(direntry, destentry, mode, group, owner, dotimes, uid, gid);
220 }
221
222 free(destdir);
223 free(direntry);
224 free(destentry);
225 closedir(dir);
226}
227
228int main(int argc, char** argv) {
229 int onlydir, dodir, dolink, dorelsymlink, dotimes, opt, len, lplen, tdlen,
230 bnlen, exists;
231 mode_t mode = 0755;
232 char *linkprefix, *owner, *group, *cp, *cwd, *todir, *toname, *name, *base,
233 *linkname, buf[BUFSIZ8192];
234 uid_t uid;
235 gid_t gid;
236 struct stat sb, tosb, fromsb;
237
238 program = argv[0];
239 cwd = linkname = linkprefix = owner = group = 0;
240 onlydir = dodir = dolink = dorelsymlink = dotimes = lplen = 0;
241
242 while ((opt = getopt(argc, argv, "C:DdlL:Rm:o:g:t")) != EOF(-1)) {
1
Assuming the condition is false
→
2
←
Loop condition is false. Execution continues on line 279
→
243 switch (opt) {
244 case 'C':
245 cwd = optarg;
246 break;
247 case 'D':
248 onlydir = 1;
249 break;
250 case 'd':
251 dodir = 1;
252 break;
253 case 'L':
254 linkprefix = optarg;
255 lplen = strlen(linkprefix);
256 dolink = 1;
257 break;
258 case 'R':
259 dolink = dorelsymlink = 1;
260 break;
261 case 'm':
262 mode = strtoul(optarg, &cp, 8);
263 if (mode == 0 && cp == optarg) usage();
264 break;
265 case 'o':
266 owner = optarg;
267 break;
268 case 'g':
269 group = optarg;
270 break;
271 case 't':
272 dotimes = 1;
273 break;
274 default:
275 usage();
276 }
277 }
278
279 argc -= optind;
280 argv += optind;
281 if (argc < 2 - onlydir) usage();
3
←
Assuming the condition is false
→
4
←
Taking false branch
→
282
283 todir = argv[argc - 1];
284 if ((stat(todir, &sb) < 0 || !S_ISDIR(sb.st_mode)((((sb.st_mode)) & 0170000) == (0040000))) &&
5
←
Assuming the condition is false
→
6
←
Assuming the condition is true
→
285 mkdirs(todir, 0777) < 0) {
286 fail("cannot make directory %s", todir);
287 }
288 if (onlydir
6.1
'onlydir' is 0
) return 0;
7
←
Taking false branch
→
289
290 if (!cwd
7.1
'cwd' is null
) {
8
←
Taking true branch
→
291#ifndef NEEDS_GETCWD
292# ifndef GETCWD_CANT_MALLOC
293 cwd = getcwd(0, PATH_MAX4096);
294# else
295 cwd = malloc(PATH_MAX4096 + 1);
296 cwd = getcwd(cwd, PATH_MAX4096);
297# endif
298#else
299 cwd = malloc(PATH_MAX4096 + 1);
300 cwd = getwd(cwd);
301#endif
302 }
303
304 xchdir(todir);
305#ifndef NEEDS_GETCWD
306# ifndef GETCWD_CANT_MALLOC
307 todir = getcwd(0, PATH_MAX4096);
308# else
309 todir = malloc(PATH_MAX4096 + 1);
310 todir = getcwd(todir, PATH_MAX4096);
311# endif
312#else
313 todir = malloc(PATH_MAX4096 + 1);
314 todir = getwd(todir);
315#endif
316 tdlen = strlen(todir);
317 xchdir(cwd);
318 tdlen = strlen(todir);
319
320 uid = owner
8.1
'owner' is null
 ? touid(owner) : (uid_t)(-1);
9
←
'?' condition is false
→
321 gid = group
9.1
'group' is null
 ? togid(group) : (gid_t)(-1);
10
←
'?' condition is false
→
322
323 while (--argc > 0) {
11
←
Loop condition is true. Entering loop body
→
324 name = *argv++;
325 len = strlen(name);
326 base = xbasename(name);
327 bnlen = strlen(base);
328 toname = xmalloc((unsigned int)(tdlen + 1 + bnlen + 1));
329 sprintf(toname, "%s%s%s", todir, _DIRECTORY_SEPARATOR"/", base);
330 exists = (lstat(toname, &tosb) == 0);
12
←
Assuming the condition is false
→
331
332 if (dodir
12.1
'dodir' is 0
) {
13
←
Taking false branch
→
333 /* -d means create a directory, always */
334 if (exists && !S_ISDIR(tosb.st_mode)((((tosb.st_mode)) & 0170000) == (0040000))) {
335 (void)unlink(toname);
336 exists = 0;
337 }
338 if (!exists && mkdir(toname, mode) < 0)
339 fail("cannot make directory %s", toname);
340 if ((owner || group) && chown(toname, uid, gid) < 0)
341 fail("cannot change owner of %s", toname);
342 } else if (dolink
13.1
'dolink' is 0
) {
343 if (access(name, R_OK4) != 0) {
344 fail("cannot access %s", name);
345 }
346 if (*name == '/') {
347 /* source is absolute pathname, link to it directly */
348 linkname = 0;
349 } else {
350 if (linkprefix) {
351 /* -L prefixes names with a $cwd arg. */
352 len += lplen + 1;
353 linkname = xmalloc((unsigned int)(len + 1));
354 sprintf(linkname, "%s/%s", linkprefix, name);
355 } else if (dorelsymlink) {
356 /* Symlink the relative path from todir to source name. */
357 linkname = xmalloc(PATH_MAX4096);
358
359 if (*todir == '/') {
360 /* todir is absolute: skip over common prefix. */
361 lplen = relatepaths(todir, cwd, linkname);
362 strcpy(linkname + lplen, name);
363 } else {
364 /* todir is named by a relative path: reverse it. */
365 reversepath(todir, name, len, linkname);
366 xchdir(cwd);
367 }
368
369 len = strlen(linkname);
370 }
371 name = linkname;
372 }
373
374 /* Check for a pre-existing symlink with identical content. */
375 if (exists &&
376 (!S_ISLNK(tosb.st_mode)((((tosb.st_mode)) & 0170000) == (0120000)) || readlink(toname, buf, sizeof buf) != len ||
377 strncmp(buf, name, (unsigned int)len) != 0 ||
378 ((stat(name, &fromsb) == 0) && (fromsb.st_mtimest_mtim.tv_sec > tosb.st_mtimest_mtim.tv_sec)))) {
379 (void)(S_ISDIR(tosb.st_mode)((((tosb.st_mode)) & 0170000) == (0040000)) ? rmdir : unlink)(toname);
380 exists = 0;
381 }
382 if (!exists && symlink(name, toname) < 0)
383 fail("cannot make symbolic link %s", toname);
384#ifdef HAVE_LCHOWN
385 if ((owner || group) && lchown(toname, uid, gid) < 0)
386 fail("cannot change owner of %s", toname);
387#endif
388
389 if (linkname) {
390 free(linkname);
391 linkname = 0;
392 }
393 } else {
394 /* Copy from name to toname, which might be the same file. */
395 if (stat(name, &sb) == 0 && S_IFDIR0040000 & sb.st_mode) {
14
←
Assuming the condition is false
→
396 /* then is directory: must explicitly create destination dir */
397 /* and manually copy files over */
398 copydir(name, todir, mode, group, owner, dotimes, uid, gid);
399 } else {
400 copyfile(name, toname, mode, group, owner, dotimes, uid, gid);
15
←
Calling 'copyfile'
→
401 }
402 }
403
404 free(toname);
405 }
406
407 free(cwd);
408 free(todir);
409 return 0;
410}