Attachment 9003143 Details for Bug 1466427

Bug 1466427 - Migrate clang-tidy package from 5.0.1 to 7.0.0-rc2. r=janx,r=glandium (edit details)
phabricator-D3980-url.txt (text/x-phabricator-request), 46 bytes, created by
(hide)
 
Size: 46 bytes
Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:
Generating Preview...

  
Flags: Requestee:
janx:
glandium:

addl.
Actions: View
Attachments on bug 1466427: 8996750 | 8996751 | 9003143 | 9003773

How would you rate the reviewability of this patch?

How would you rate the necessity of this patch?

How long did you take to review this patch?
What aspects of this patch, if any, contribute to its reviewability?What aspects of this patch, if any, should be improved to enhance its reviewability?